Use spread operator instead of Object.assign call #1898

MichaelDeBoey · 2019-05-13T22:26:11Z

What kind of change does this PR introduce?
Code refactor

What is the current behavior?

What is the new behavior?

Checklist:

SaraVieira · 2019-05-22T20:44:15Z

Hey!

Can you please revert the changes inside the overmind folder? We have christian doing a complete refactor of that part :(

That folder exists for the migartion to overmind

MichaelDeBoey · 2019-05-22T20:45:38Z

On it 🙂

packages/app/src/sandbox/eval/loaders/@babel-runtime.no-webpack.js

SaraVieira · 2019-05-22T22:16:14Z

Awesome! Thank you and thank you for the changes :)

MichaelDeBoey · 2019-05-22T22:18:55Z

Always a pleasure! 🙂

MichaelDeBoey force-pushed the object-assign branch 4 times, most recently from cc2c9bb to 4f28a4a Compare May 20, 2019 10:09

MichaelDeBoey force-pushed the object-assign branch 2 times, most recently from 35ebfb8 to f4d6251 Compare May 21, 2019 11:39

SaraVieira reviewed May 22, 2019

View reviewed changes

packages/app/src/sandbox/eval/loaders/@babel-runtime.no-webpack.js Outdated Show resolved Hide resolved

MichaelDeBoey force-pushed the object-assign branch from f4d6251 to 757b91a Compare May 22, 2019 20:47

MichaelDeBoey added 3 commits May 22, 2019 22:55

Use spread operator instead of Object.assign call

13f6c57

Revert overmind folder

3f16b50

Revert generated file

ea68daa

MichaelDeBoey force-pushed the object-assign branch from 757b91a to ea68daa Compare May 22, 2019 20:57

SaraVieira merged commit c1bc28a into codesandbox:master May 22, 2019

MichaelDeBoey deleted the object-assign branch May 22, 2019 22:18

Provide feedback