-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert all Medium blogposts to Markdown #2011
Convert all Medium blogposts to Markdown #2011
Conversation
@CompuIves I can't seem to figure out why the build still fails |
@CompuIves Can you help in making the decision in what to do with these 2 things please?
|
381e203
to
0942c1a
Compare
This is a really good change, great step on moving from Medium. Thanks for doing this!
I'd convert them to code blocks.
At the time I wanted to have a GIF, but it was too large. If we can embed it as a gif now that's only better. |
Will have a look how I can get the GIF from the embedded movie + will convert al the GitHub gists to code blocks 🙂 |
@CompuIves Something else I've been thinking about
|
97a0c1c
to
744f919
Compare
Hey @MichaelDeBoey , Can we do anything about the build time increasing with 2 minutes? |
@lbogdan Hmmm we need to parse and create every page ourselves so I'm not sure tbh. Building @kentcdodds' blog also takes a while, so I think this is expected behaviour. |
744f919
to
bc3d739
Compare
bc3d739
to
59761e6
Compare
d5f205b
to
f4fab18
Compare
f4fab18
to
34a0184
Compare
34a0184
to
b943e8f
Compare
b943e8f
to
e5bca37
Compare
This reverts commit 40a986f
ff01e8a
to
17a988e
Compare
This is amazing work @MichaelDeBoey, this is reaaally good. Today our deployment system has been clogged up due to our dependency on Medium. Since there are some important fixes that I want to have deployed I went ahead and made the PR mergeable. I know that the PR isn't 100% finished yet, but I think it'd be good to merge this version in already so we can get the other important bug fixes live. I'm sorry to suddenly rush this PR, it's exactly what we need right now and it's very important to me to get our deployment flow back up. Again, thanks a lot for all this work, this is suuper useful! |
No problem, I understand the need for merging it now. 🙂 |
What kind of change does this PR introduce?
I extracted all of @CompuIves' Medium posts into Markdown files (just like @kentcdodds did in his three part tutorial).
The main reason for doing this, was the fact that right now we only see 8 Medium posts + the newly created investor seed post.
This comes from the fact that we fetch all Medium posts from https://medium.com/feed/@CompuIves, which only return the last 10 created items of @CompuIves (including comments, which he has 2 of).
I've looked into alternatives to fetch all Medium posts and found that you can get them all sorted from https://medium.com/@CompuIves/latest?format=json in a (broken) JSON format.
The only problem here is that you don't get the content of the post itself.
These posts were also limited to the latest 10 articles btw.
The only things that I still need to look at are
remark-embedder
plugin when that's extracted from kentcdodds/kentcdodds.com (see Homepage image doesn't show on Safari when devtools open kentcdodds/kentcdodds.com#172 & typo kentcdodds/kentcdodds.com#227)Embed them? (This will need a change in theremark-embedder
plugin)announcing-codesandbox-2-0
Embed itLeave it outremark-embedder
plugin), since that now shows the embed instead of the text or it's a broken link (see Update what-open-source-project-should-i-contribute-to.mdx kentcdodds/kentcdodds.com#194)Will create a separate PR to delete them there and cleanup the config
Leave them outremark-embedder
plugin for Twitter accounts with 2 underscores (_
) (see Add Polish translation to "Array reduce vs chaining vs for loop" kentcdodds/kentcdodds.com#191)https://twitter.com/brian_d_vaughn/status/901488766581227520
remark-embedder
plugin.Edit 2: It seems to be a
gatsby-transformer-remark
problem (see 🐞[gatsby-transformer-remark] Link with double underscore doesn't work gatsbyjs/gatsby#14715).Edit 3:
gatsby-transformer-remark
'spedantic
option should be set tofalse
(see 🐞[gatsby-transformer-remark] Link with double underscore doesn't work gatsbyjs/gatsby#14715 (comment))Follow-ups
/post/blog-slug
to/blog/blog-slug
an redirect all old links to the new onesremark-embedder
plugin in other parts (docs, ...) too (delete thehttps://codesandbox.io/s/embed/...
links)What is the current behavior?
Having both articles from self-written Markdown files and fetched the last 8 articles from Medium
What is the new behavior?
All articles are "self-written" Markdown files and include all of @CompuIves' articles that are present on his Medium profile.
What steps did you take to test this?
yarn start:home
localhost:8000/blog
and see all articles are presentChecklist