Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all Medium blogposts to Markdown #2011

Merged
merged 39 commits into from
Jul 25, 2019

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Jun 1, 2019

What kind of change does this PR introduce?

I extracted all of @CompuIves' Medium posts into Markdown files (just like @kentcdodds did in his three part tutorial).

The main reason for doing this, was the fact that right now we only see 8 Medium posts + the newly created investor seed post.
This comes from the fact that we fetch all Medium posts from https://medium.com/feed/@CompuIves, which only return the last 10 created items of @CompuIves (including comments, which he has 2 of).

I've looked into alternatives to fetch all Medium posts and found that you can get them all sorted from https://medium.com/@CompuIves/latest?format=json in a (broken) JSON format.
The only problem here is that you don't get the content of the post itself.
These posts were also limited to the latest 10 articles btw.

The only things that I still need to look at are

Follow-ups

  • Change /post/blog-slug to /blog/blog-slug an redirect all old links to the new ones
  • Make the blog-section on the homepage work with the new Markdown files instead of only the Medium posts
  • Use the remark-embedder plugin in other parts (docs, ...) too (delete the https://codesandbox.io/s/embed/... links)

What is the current behavior?

Having both articles from self-written Markdown files and fetched the last 8 articles from Medium

What is the new behavior?

All articles are "self-written" Markdown files and include all of @CompuIves' articles that are present on his Medium profile.

What steps did you take to test this?

  • Run yarn start:home
  • Go to localhost:8000/blog and see all articles are present
  • Click on each article and see it's present

Checklist

  • Documentation N/A
  • Testing
  • Ready to be merged
  • Added myself to contributors table

MichaelDeBoey referenced this pull request in MichaelDeBoey/codesandbox-client Jun 1, 2019
@MichaelDeBoey
Copy link
Contributor Author

@CompuIves I can't seem to figure out why the build still fails
Maybe @lbogdan can have a look too? 🤔

@MichaelDeBoey
Copy link
Contributor Author

@CompuIves Can you help in making the decision in what to do with these 2 things please?

Decide what we want to do with all GitHub gists

  • Embed them? (This will need a change in the remark-embedder plugin)
  • Convert them to code blocks inside the Markdown file?

Decide what to do with the movie from announcing-codesandbox-2-0

  • Convert it to GIF
  • Embed it
  • Leave it out

@lbogdan lbogdan temporarily deployed to pr2011 June 4, 2019 23:02 Inactive
@lbogdan lbogdan temporarily deployed to pr2011 June 4, 2019 23:21 Inactive
@CompuIves
Copy link
Member

This is a really good change, great step on moving from Medium. Thanks for doing this!

Decide what we want to do with all GitHub gists

I'd convert them to code blocks.

Decide what to do with the movie from announcing-codesandbox-2-0

At the time I wanted to have a GIF, but it was too large. If we can embed it as a gif now that's only better.

@MichaelDeBoey
Copy link
Contributor Author

Will have a look how I can get the GIF from the embedded movie + will convert al the GitHub gists to code blocks 🙂

@lbogdan lbogdan temporarily deployed to pr2011 June 5, 2019 09:41 Inactive
@MichaelDeBoey
Copy link
Contributor Author

@CompuIves Something else I've been thinking about

Decide what to do with all the image (and sandbox) descriptions

  • Leave them out
  • Show them too

@lbogdan
Copy link
Contributor

lbogdan commented Jun 6, 2019

Hey @MichaelDeBoey ,

Can we do anything about the build time increasing with 2 minutes?

@MichaelDeBoey
Copy link
Contributor Author

@lbogdan Hmmm we need to parse and create every page ourselves so I'm not sure tbh.

Building @kentcdodds' blog also takes a while, so I think this is expected behaviour.

@CompuIves
Copy link
Member

This is amazing work @MichaelDeBoey, this is reaaally good. Today our deployment system has been clogged up due to our dependency on Medium. Since there are some important fixes that I want to have deployed I went ahead and made the PR mergeable.

I know that the PR isn't 100% finished yet, but I think it'd be good to merge this version in already so we can get the other important bug fixes live.

I'm sorry to suddenly rush this PR, it's exactly what we need right now and it's very important to me to get our deployment flow back up. Again, thanks a lot for all this work, this is suuper useful!

@CompuIves CompuIves marked this pull request as ready for review July 25, 2019 20:57
@CompuIves CompuIves merged commit c3a3a4d into codesandbox:master Jul 25, 2019
@MichaelDeBoey MichaelDeBoey deleted the medium-to-markdown branch July 26, 2019 00:02
@MichaelDeBoey
Copy link
Contributor Author

No problem, I understand the need for merging it now. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants