Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃敤 Refactored 馃 Overmind Hacktober | app/pages/index.tsx : refactor to replace Cerebral with Overmind #2630

Merged
merged 1 commit into from Oct 3, 2019
Merged

馃敤 Refactored 馃 Overmind Hacktober | app/pages/index.tsx : refactor to replace Cerebral with Overmind #2630

merged 1 commit into from Oct 3, 2019

Conversation

chinmayhem
Copy link
Contributor

@chinmayhem chinmayhem commented Oct 3, 2019 •
edited

What kind of change does this PR introduce?

Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni

What is the current behavior?

app/pages/index.tsx was using inject and hooksObserver from app/componentConnectors

What is the new behavior?

uses useOvermind from app/overmind

What steps did you take to test this?

Opened the homepage, /s/new page
ran yarn lint and yarn typecheck

Checklist

  • Documentation: N/A
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@vercel vercel bot temporarily deployed to staging October 3, 2019 17:03 Inactive
@vercel
Copy link

vercel bot commented Oct 3, 2019 •
edited

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://codesandbox-client-git-fork-chinmay17-refactor-app-pages-index.codesandbox1.now.sh

@chinmayhem chinmayhem changed the title app/pages/index.tsx : refactor to replace Cerebral with Overmind 馃敤 Refactored 馃 Overmind Hacktober | app/pages/index.tsx : refactor to replace Cerebral with Overmind Oct 3, 2019
@chinmayhem chinmayhem mentioned this pull request Oct 3, 2019
Closed
84 tasks
SaraVieira
SaraVieira approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@SaraVieira
Copy link
Contributor

Thank you so much 馃帀

@SaraVieira SaraVieira merged commit 8ad2cbe into codesandbox:master Oct 3, 2019
@SaraVieira
Copy link
Contributor

@all-contributors bot please add chinmay17 for code

@allcontributors allcontributors bot mentioned this pull request Oct 3, 2019
Merged
@allcontributors
Copy link
Contributor

@SaraVieira

I've put up a pull request to add @chinmay17! 馃帀

@chinmayhem
Copy link
Contributor Author

@SaraVieira Woah! That was quick! This is my first open-source PR getting merged. And that too for codesandbox! Thank you so much!

@chinmayhem chinmayhem deleted the refactor-app-pages-index branch October 3, 2019 17:37
@Saeris Saeris added Hacktoberfest 馃敤 Refactor 馃 Overmind Indicates that this is related to the app's State Management labels Oct 3, 2019
@MichaelDeBoey MichaelDeBoey mentioned this pull request Oct 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaraVieira SaraVieira SaraVieira approved these changes

Assignees
No one assigned
Labels
馃 Overmind Indicates that this is related to the app's State Management 馃敤 Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chinmayhem @SaraVieira @Saeris