-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored | Overmind Hacktober | /app/pages/common/Modals/NetlifyLogs/index.js #2727
Refactored | Overmind Hacktober | /app/pages/common/Modals/NetlifyLogs/index.js #2727
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/bzxjv5kyz |
56ee4e5
to
13a266a
Compare
13a266a
to
a6a38fd
Compare
0d1e82e
to
32102ca
Compare
This is great, thanks a lot! Did you also verify seeing the Netlify Logs? |
I have no idea how to do that |
You can do this by forking a sandbox, then looking in the sidebar at deployments, there deploy the sandbox with Netlify and then check the logs (View Logs button). Let me know if you could use help with this! |
I tried to test with below link. is it correct url? |
Can you please pull from master and that is solved? After that you can login |
32102ca
to
6d33856
Compare
Build for latest commit 6d33856 is at https://pr2727.build.csb.dev/s/new. |
I wonder why i do not see "Deploy" button with latest commit build( https://pr2727.build.csb.dev/s/new). Please note that i pushed the code post re-basing master. |
Although i can see logs of another project which i deployed yesterday from production app(https://codesandbox.io/). |
Hey! Angular does not work with netlify. You can see it in vue or react projects for example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me to 🎉
What kind of change does this PR introduce?
Refactor code for hacktoberfest #2621
What is the current behavior?
/app/pages/common/Modals/NetlifyLogs/index.js
was using inject and observer from app/componentConnectorsWhat is the new behavior?
useOvermind
fromapp/overmind
andjs
file converted totsx
fileWhat steps did you take to test this? This is required before we can merge.
yarn:lint
: There were several linting errors, but none relevant to the scope of this PRyarn:test
: Ran successfullyChecklist