Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored | Overmind Hacktober | /app/pages/common/Modals/NetlifyLogs/index.js #2727

Merged

Conversation

NileshPatel17
Copy link
Contributor

What kind of change does this PR introduce?

Refactor code for hacktoberfest #2621

What is the current behavior?

/app/pages/common/Modals/NetlifyLogs/index.js was using inject and observer from app/componentConnectors

What is the new behavior?

  1. converted class component to functional component
  2. uses useOvermind from app/overmind and js file converted to tsx file

What steps did you take to test this? This is required before we can merge.

  1. yarn:lint: There were several linting errors, but none relevant to the scope of this PR
  2. yarn:test: Ran successfully

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@vercel
Copy link

vercel bot commented Oct 10, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/bzxjv5kyz
🌍 Preview: https://codesandbox-cl-git-fork-nileshpatel17-issue2621-models-n-f6a020.codesandbox1.now.sh

@vercel vercel bot temporarily deployed to staging October 10, 2019 17:50 Inactive
@vercel vercel bot temporarily deployed to staging October 11, 2019 12:48 Inactive
@vercel vercel bot temporarily deployed to staging October 11, 2019 12:50 Inactive
@vercel vercel bot temporarily deployed to staging October 11, 2019 12:53 Inactive
@vercel vercel bot temporarily deployed to staging October 11, 2019 12:59 Inactive
@vercel vercel bot temporarily deployed to staging October 11, 2019 13:01 Inactive
@CompuIves
Copy link
Member

This is great, thanks a lot! Did you also verify seeing the Netlify Logs?

@NileshPatel17
Copy link
Contributor Author

I have no idea how to do that

@Saeris Saeris added Hacktoberfest 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Oct 13, 2019
@CompuIves
Copy link
Member

You can do this by forking a sandbox, then looking in the sidebar at deployments, there deploy the sandbox with Netlify and then check the logs (View Logs button). Let me know if you could use help with this!

@NileshPatel17
Copy link
Contributor Author

I tried to test with below link. is it correct url?
https://pr2727.build.csb.dev/s/new
I am unable to login with github
image

@SaraVieira
Copy link
Contributor

Can you please pull from master and that is solved?

After that you can login

@lbogdan
Copy link
Contributor

lbogdan commented Oct 22, 2019

Build for latest commit 6d33856 is at https://pr2727.build.csb.dev/s/new.

@NileshPatel17
Copy link
Contributor Author

NileshPatel17 commented Oct 22, 2019

I wonder why i do not see "Deploy" button with latest commit build( https://pr2727.build.csb.dev/s/new). Please note that i pushed the code post re-basing master.
image

i am unable to sign-in either
image

@NileshPatel17
Copy link
Contributor Author

NileshPatel17 commented Oct 22, 2019

Although i can see logs of another project which i deployed yesterday from production app(https://codesandbox.io/).
image

@SaraVieira
Copy link
Contributor

Hey!

Angular does not work with netlify. You can see it in vue or react projects for example

@NileshPatel17
Copy link
Contributor Author

Tested with react project, and it looks good. i can see the logs.
image

Copy link
Contributor

@SaraVieira SaraVieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me to 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants