Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔨 Refactored 🧠 Overmind Hacktober | Editor/Workspace/items/Deployment/Zeit/Deploys/Actions/AliasDeploymentButton/AliasDeploymentButton.tsx : refactor to replace Cerebral with Overmind #2742

Merged
merged 2 commits into from Oct 17, 2019
Merged

🔨 Refactored 🧠 Overmind Hacktober | Editor/Workspace/items/Deployment/Zeit/Deploys/Actions/AliasDeploymentButton/AliasDeploymentButton.tsx : refactor to replace Cerebral with Overmind #2742

merged 2 commits into from Oct 17, 2019

Conversation

hetpatel33
Copy link
Contributor

@hetpatel33 hetpatel33 commented Oct 12, 2019 •
edited

What kind of change does this PR introduce?

Refactors code as a part of hacktoberfest mentioned in #2621.
@Saeris @christianalfoni @SaraVieira

What is the current behavior?

What is the new behavior?

What steps did you take to test this? This is required before we can merge.

  1. Step A
  2. Step B
  3. Step C

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@hetpatel33
Refactor Editor/Workspace/items/Deployment/Zeit/Deploys/Actions/Alias…
4027882 
…DeploymentButton/AliasDeploymentButton.tsx : convert to ts and replace Cerebral with Overmind
@vercel
Copy link

vercel bot commented Oct 12, 2019 •
edited

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/4t1w3ntuz
🌍 Preview: https://codesandbox-cl-git-fork-hetpatel33-refactor-editor-works-bbdf09.codesandbox1.now.sh

@vercel vercel bot temporarily deployed to staging October 12, 2019 11:09 Inactive
@hetpatel33 hetpatel33 mentioned this pull request Oct 12, 2019
Closed
84 tasks
@vercel vercel bot temporarily deployed to staging October 12, 2019 11:23 Inactive
@Saeris Saeris added Hacktoberfest 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Oct 13, 2019
CompuIves
CompuIves approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@CompuIves CompuIves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is clean! Thanks for the contribution.

@CompuIves CompuIves merged commit 9937d18 into codesandbox:master Oct 17, 2019
@MichaelDeBoey MichaelDeBoey mentioned this pull request Oct 18, 2019
Closed
@MichaelDeBoey MichaelDeBoey mentioned this pull request Dec 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CompuIves CompuIves CompuIves approved these changes

Assignees
No one assigned
Labels
🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hetpatel33 @CompuIves @Saeris