-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃敤 Refactor Editor/Workspace/Files #2860
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build for latest commit 468801f is at https://pr2860.build.csb.dev/s/new. |
84 tasks
Hey! Sorry for the delay :( Thank you so much! |
No problem! Glad to contribute! |
MichaelDeBoey
added
the
馃 Overmind
Indicates that this is related to the app's State Management
label
Feb 14, 2020
This was referenced Jan 12, 2022
This was referenced Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor.
What is the current behavior?
Works the same way but using
Cerebral
.What is the new behavior?
This PR refactors
app/src/app/pages/Sandbox/Editor/Workspace/Files/index.js
to TS usinguseOvermind
.What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
yarn test
yarn lint
yarn typecheck
Checklist
cc/ @Saeris @christianalfoni