Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敤 Refactor Editor/Workspace/Files #2860

Merged
merged 4 commits into from
Dec 9, 2019

Conversation

ivandevp
Copy link
Contributor

@ivandevp ivandevp commented Oct 18, 2019

What kind of change does this PR introduce?

Refactor.

What is the current behavior?

Works the same way but using Cerebral.

What is the new behavior?

This PR refactors app/src/app/pages/Sandbox/Editor/Workspace/Files/index.js to TS using useOvermind.

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

  1. Manually tested it to check that it still works
  2. yarn test
  3. yarn lint
  4. yarn typecheck

Checklist

  • Testing
  • Ready to be merged
  • Added myself to contributors table

cc/ @Saeris @christianalfoni

@lbogdan lbogdan temporarily deployed to pr2860 October 18, 2019 22:31 Inactive
@lbogdan lbogdan temporarily deployed to pr2860 October 19, 2019 21:14 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Oct 19, 2019

Build for latest commit 468801f is at https://pr2860.build.csb.dev/s/new.

@SaraVieira
Copy link
Contributor

Hey!

Sorry for the delay :(

Thank you so much!

@ivandevp
Copy link
Contributor Author

ivandevp commented Dec 9, 2019

No problem! Glad to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃 Overmind Indicates that this is related to the app's State Management 馃敤 Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants