Google Fonts picker - remove need for google api #3050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build for latest commit 0f0f685 is at https://pr3050.build.csb.dev/s/new. |
SaraVieira
changed the title
siddharthkp
reviewed
Nov 21, 2019
| import Color from 'color'; | ||
|
|
||
| const svg = props => |
There was a problem hiding this comment.
For later: oh noes, would be cool to drop this in a file so it's discoverable?
There was a problem hiding this comment.
Honestly I don't think we will ever used this again, I could have done in css now that I think of it
siddharthkp
reviewed
Nov 21, 2019
packages/app/src/app/pages/Sandbox/Editor/Workspace/Dependencies/AddFont/FontPicker/elements.ts
Show resolved
Hide resolved
|
|
|
Yeah! Something is wrong with the build, I am gonna talk to bogdan |
|
Merge with master should fix it!
…On Thu, 21 Nov 2019 at 13:23, Sara Vieira ***@***.***> wrote:
Yeah! Something is wrong with the build, I am gonna talk to bogdan
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#3050?email_source=notifications&email_token=AAEPKCCKGU3AAI5ROS5IPK3QUZVRTA5CNFSM4JPWMXQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEZ4QTQ#issuecomment-557041742>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEPKCAZKV64RHBU5JZA4T3QUZVRTANCNFSM4JPWMXQA>
.
|
This was referenced Jan 12, 2022
This was referenced Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google api was needed because of the display of the font in his style and with that removed there is no need to use an api key