Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Textarea To Components #3292

Merged
merged 17 commits into from Jan 8, 2020
Merged

Add Textarea To Components #3292

merged 17 commits into from Jan 8, 2020

Conversation

SaraVieira
Copy link
Contributor

  • Adds textarea
  • Adds max length logic
  • changes labels to extend Text component

@lbogdan lbogdan temporarily deployed to pr3292 January 8, 2020 12:00 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Jan 8, 2020 •
edited

Build for latest commit f5992e6 is at https://pr3292.build.csb.dev/s/new.

siddharthkp
siddharthkp reviewed Jan 8, 2020
View reviewed changes
packages/components/src/components/Textarea/index.tsx
[maxLength]
);

// eslint-disable-next-line consistent-return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

freaking hate that rule

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can turn it off in this package, what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yaaas!

@siddharthkp siddharthkp mentioned this pull request Jan 8, 2020
Merged
@lbogdan lbogdan temporarily deployed to pr3292 January 8, 2020 13:40 Inactive
@lbogdan lbogdan temporarily deployed to pr3292 January 8, 2020 13:58 Inactive
@siddharthkp siddharthkp added the UI label Jan 8, 2020
@SaraVieira SaraVieira merged commit 60684d1 into master Jan 8, 2020
@SaraVieira SaraVieira deleted the textarea branch January 8, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharthkp siddharthkp siddharthkp approved these changes

Assignees
No one assigned
Labels
UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SaraVieira @lbogdan @siddharthkp