Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ability to change themes #3308

Merged
merged 3 commits into from Jan 13, 2020
Merged

add ability to change themes #3308

merged 3 commits into from Jan 13, 2020

Conversation

SaraVieira
Copy link
Contributor

Adds most vscodeThemes to a theme switcher so we can test our components in all themes

@lbogdan lbogdan temporarily deployed to pr3308 January 10, 2020 14:28 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Jan 10, 2020 •
edited

Build for latest commit 61b0191 is at https://pr3308.build.csb.dev/s/new.

siddharthkp
siddharthkp approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally, works really well!

@siddharthkp siddharthkp merged commit f778ba0 into master Jan 13, 2020
@siddharthkp siddharthkp deleted the theme-switcher branch January 13, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharthkp siddharthkp siddharthkp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SaraVieira @lbogdan @siddharthkp