Support all prettier config files

[pablopunk]

What kind of change does this PR introduce?

Feature

What is the current behavior?

package.json "prettier" config is ignored

What is the new behavior?

Prettier config will be, in order of precedence:

• "prettier" key in package.json, if it exists
• prettierrc file in the root of the sandbox
• sandbox prettier config (via preferences)
• default prettier config

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

Tested all of the above scenarios

Checklist

• Documentation
• Testing
• Ready to be merged
  
• Added myself to contributors table
  

This addresses only part of issue #1980. I didn't implement all the possible configuration files just to keep it simple.

Another thing I wanted to mention, I notice there's another function to get the prettier config here but I didn't manage to see where's being used. Is it being used at all?

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7685d68:

Sandbox	Source
Notifications Test	Configuration

[lbogdan]

Build for latest commit 7685d68 failed.

[SaraVieira]

👋

Thank you so much, I'm on my way to a meeting but will review when I get back home

Question would this be possible?. #1980

[pablopunk]

@SaraVieira sure, it will require to parse YAML and TOML and a few more checks for the files existing, but it is possible. I can do them all if that's what we want

[SaraVieira]

We do have a toml one installed already. its called markty-toml and it's used for netlifly configs here:

codesandbox-client/packages/app/src/app/utils/getNetlifyConfig.js

Line 2 in b4937ea

import toml from 'markty-toml';

We do not have a YAML one so I am okay with letting that one go and also the TOML one if it's too hard, it's mostly just for the names you can give the prettier config files :)

Mostly this version: prettier.config.js

[SaraVieira]

Also ping me if you need any help

[MichaelDeBoey]

@pablopunk Maybe there's some cosmiconfig logic we can (re-)use? 🤔
It's used by a lot of libraries (like eslint, prettier, ...) to get the config of all the different supported files.

[pablopunk]

@MichaelDeBoey I did take a look at that but they look for the files in the filesystem (with node)

[pablopunk]

@SaraVieira I wanna resolve a module from a path (get the value of module.exports) right here, what's the convention on codesandbox? I know it uses eval, can I see an example?

[SaraVieira]

Hey!

Gonna ping @CompuIves as he might be able to help you better there

[github-actions]

This PR has automatically been marked stale because there has been no activity in a while. Please leave a comment if the issue has not been resolved, or if it is not stale for any other reason. After 2 weeks, this issue will automatically be closed, unless a comment is made or the stale label is removed.

[github-actions]

This PR has been automatically closed because there wasn't any activity after the previous notice or the stale label wasn't removed.