Fix resolving dynamic dependencies #4940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a race condition where the parents of a transient dependency weren't properly marked. Which cause some dependencies to be merged wrongly. Fixes #4898
|
Build for latest commit c8348b4 is at https://pr4940.build.csb.dev/s/new. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c8348b4:
|
This also improves our detection heuristic for JSX modules Fixes #4929
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a race condition where the parents of a transient dependency weren't properly
marked. Which cause some dependencies to be merged wrongly.
This also fixes how we print unicode characters with our transpiler (as a unicode character instead) and how we detect JSX. From now on if there's an AST we use that to detect JSX rather than RegEx, we do still fall back to RegEx if there's no AST available.
Fixes #4898
Fixes #4929