Add extra validation for showing delete template #5109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build for latest commit 031c25d is at https://pr5109.build.csb.dev/s/new. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 031c25d:
|
CompuIves
reviewed
Nov 11, 2020
| return false; | ||
| } | ||
|
|
||
| return true; |
There was a problem hiding this comment.
We might need to check if author id on the sandbox is the same as current user ID. Other than that this looks good!
There was a problem hiding this comment.
But in teams you can delete other people's templates, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, to delete a template we let you do it if the template's team is null and this resulted in people having a button to delete recently used templates that had no team but also had no author id either
These are Github templates you cannot delete
This adds a check for that
closes #5026