fix(router): keep existing state when replacing

[posva]

What kind of change does this PR introduce?

This is a proposal rather than a fix. I would say that the state should be preserved when calling history.replaceState instead of being deleted. I came from #4905 but I don't remember anymore a case where the current solution would fail...

What is the current behavior?

What is the new behavior?

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

1. Step A
2. Step B
3. Step C

Checklist

• Documentation
• Testing
• Ready to be merged
  
• Added myself to contributors table
  

[lbogdan]

Build for latest commit 2adeb22 is at https://pr5302.build.csb.dev/s/new.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2adeb22:

Sandbox	Source
Notifications Test	Configuration

[github-actions]

This PR has automatically been marked stale because there has been no activity in a while. Please leave a comment if the issue has not been resolved, or if it is not stale for any other reason. After 2 weeks, this issue will automatically be closed, unless a comment is made or the stale label is removed.

[posva]

Check

[danilowoz]

Thanks for helping us clean up!

This PR does not seem to improve user or developer experience in a noticeable way, even fixing any bug. We are very sorry that you spent time on this, only to see us closing the PR. But we hope you understand our reasoning and do not feel discouraged to make other contributions 😄

[posva]

Sure. I don't remember anymore but if this replaceState() was called for the window on the right of code sandbox, then it should be changed with the proposal as replaceState() and removing the current state will break client side routing that relies on the history state like Vue Router 4.

If it's about the codesandbox application itself, then it doesn't matter