fix(router): keep existing state when replacing #5302
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This is a proposal rather than a fix. I would say that the state should be preserved when calling
history.replaceState
instead of being deleted. I came from #4905 but I don't remember anymore a case where the current solution would fail...What is the current behavior?
What is the new behavior?
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
Checklist