Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added External Resources back to Vanilla #6634

Closed
wants to merge 2 commits into from

Conversation

Akash-Ramjyothi
Copy link

@Akash-Ramjyothi Akash-Ramjyothi commented Apr 15, 2022

What kind of change does this PR introduce?

Added the external resources back to vanilla to improve the code quality.

Checklist

  • Documentation
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit efbe551:

Sandbox Source
Notifications Test Configuration

@lbogdan
Copy link
Contributor

lbogdan commented Apr 15, 2022

Build for latest commit efbe551 is at https://pr6634.build.csb.dev/s/new.

@lbogdan
Copy link
Contributor

lbogdan commented Apr 15, 2022

Hey @Akash-Ramjyothi , I'm seeing quite a few PRs from you, thanks for your contribution!

Before we go ahead and review them, please make sure they only change the intended files, as right now some of them delete / change permissions of unrelated files.

@Akash-Ramjyothi
Copy link
Author

Superseded by #6697 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants