[Feature] WIP: Keybindings added to navigate between tabs. #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grady-lad
changed the title
|
Yeah, it would be super cool if there will be any shortcuts for tabs navigation. When aprox it will be merged? |
|
Consider this shortcuts: CTRL + J, CTRL + K, very handy in my opition |
|
Hey! Sorry for the quiet time and for I am about to say but due to us changing to VSCode this is now handled by VSCode so we don't need that extra logic Sorry again and thank you for taking the time to contribute |
This was referenced Sep 1, 2021
This was referenced Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This feature introduces two new keybindings:
Switch To Next Tab&Switch To Previous TabWhat is the current behavior?
See #761
What is the new behavior?
Switch To Next Tab:Keybinding allowing users to create a shortcut to switch to the next tabSwitch To Previous Tab:Keybinding allowing users to create a shortcut to switch to the previous tabChecklist:
Additional comments
I have introduced the functionality to switch between tabs in both directions. When testing the PR it seems I ran into a few snags:
I found it hard to find appropriate default keybinding values that worked, as some were taken by the browser. Open to suggestions here as to what they should be and if they should be able to overwrite browser defaults?
Also in terms of usability if a keybinding was created with multiple keys eg.
Control + Safter the first execution I would expect the keybinding to still execute if the user heldControland repeatedly pressedS, currently this is not the situation. To switch to the next tab the user has to repeatedly pressControl + SPlease Note: The default keybindings in the PR are not final they were just used for testing purposes and can be changed to more appropriate keys