Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong use of addEventListener/removeEventListener #897

Merged
merged 1 commit into from
Jun 11, 2018

Conversation

cottom
Copy link
Contributor

@cottom cottom commented Jun 11, 2018

What kind of change does this PR introduce?

addEventListener just return undefined not Function;
https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener

What is the current behavior?

What is the new behavior?

Same as before;

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@CompuIves
Copy link
Member

Oh wow, that's a big mistake of me! Thanks for fixing this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants