Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows opening tests by default with share link #959

Merged
merged 5 commits into from
Jul 21, 2018
Merged

Allows opening tests by default with share link #959

merged 5 commits into from
Jul 21, 2018

Conversation

satyarohith
Copy link
Contributor

@satyarohith satyarohith commented Jul 14, 2018

What kind of change does this PR introduce?
This PR helps us to have an option to set Tests view instead of Browser view when sharing sandboxes.

What is the current behavior?

What is the new behavior?
shareviews

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

closes #958

@satyarohith satyarohith changed the title figuring outot out 😕 [WIP] Allows opening tests by default with share link Jul 14, 2018
@satyarohith satyarohith changed the title [WIP] Allows opening tests by default with share link Allows opening tests by default with share link Jul 14, 2018
@satyarohith
Copy link
Contributor Author

@CompuIves let me know whether this is useful since we can also achieve this from sandbox config files. :)

@CompuIves
Copy link
Member

Yes! This is what we need! 😄

Could you also add the options to our docs? https://github.com/CompuIves/codesandbox-client/blob/master/packages/homepage/content/docs/2-embedding.md

@satyarohith
Copy link
Contributor Author

Everything is done, Ives! 😃 Let me know if anything is missing.

@CompuIves
Copy link
Member

This is almost done! The last thing we need to do is make it work in the embed, which can be done by setting the proper property here: https://github.com/CompuIves/codesandbox-client/blob/0fe309992d04fe0fc958c0125210893a90e53c73/packages/app/src/embed/components/Content/index.js#L436.

@satyarohith
Copy link
Contributor Author

@CompuIves It works 🎉
Right now, preference is given to URL option if both config file and URL option are set.
Let me know what do you think? 😄

@CompuIves
Copy link
Member

This is perfect @satyarohith, thanks a lot for the help! I'll let the build run now and merge it in as soon everything turns green. 😄🎉:shipit:

@CompuIves CompuIves merged commit 4525c1c into codesandbox:master Jul 21, 2018
@kentcdodds
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow opening tests by default with share link
3 participants