fix(SandpackConsole): clear logs based on maxMessageCount option #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SSHari is attempting to deploy a commit to the CodeSandbox Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 189fb90:
|
danilowoz
approved these changes
Apr 1, 2023
| @@ -67,7 +67,7 @@ export const useSandpackConsole = ({ | |||
| } | |||
| ); | |||
|
|
|||
| while (messages.length > MAX_MESSAGE_COUNT) { | |||
| while (messages.length > maxMessageCount) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this pull request introduce?
This fixes a bug with the
Consolecomponent where themaxMessageCountoption isn't respected.What is the current behavior?
The
maxMessageCountoption is ignored and instead the defaultMAX_MESSAGE_COUNTvalue is used when determining if old logs should be cleaned up.#865
What is the new behavior?
The
maxMessageCountis respected so that logs are cleaned up based on what the user specifies.What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
EditorandConsolecomponentmaxMessageCountoptionvanilla(client) andnode(server) templates by logging more lines than themaxMessageCountoptionChecklist