Skip to content

Commit

Permalink
enhancement: undo upper limit on timeout
Browse files Browse the repository at this point in the history
  • Loading branch information
codesenberg committed Nov 22, 2017
1 parent 2b9bac8 commit 00d7965
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 19 deletions.
2 changes: 0 additions & 2 deletions common.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ var (
"Invalid test duration(must be >= 1s)")
errNegativeTimeout = errors.New(
"Timeout can't be negative")
errLargeTimeout = errors.New(
"Timeout is too big(more that 10s)")
errBodyNotAllowed = errors.New(
"GET and HEAD requests cannot have body")
errNoPathToCert = errors.New(
Expand Down
3 changes: 0 additions & 3 deletions config.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,6 @@ func (c *config) checkTimeoutDuration() error {
if c.timeout < 0 {
return errNegativeTimeout
}
if c.timeout > 10*time.Second {
return errLargeTimeout
}
return nil
}

Expand Down
14 changes: 0 additions & 14 deletions config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ func TestCheckArgs(t *testing.T) {
invalidNumberOfReqs := uint64(0)
smallTestDuration := 99 * time.Millisecond
negativeTimeoutDuration := -1 * time.Second
bigTimeoutDuration := 900 * time.Second
noHeaders := new(headersList)
zeroRate := uint64(0)
expectations := []struct {
Expand Down Expand Up @@ -125,19 +124,6 @@ func TestCheckArgs(t *testing.T) {
},
errNegativeTimeout,
},
{
config{
numConns: defaultNumberOfConns,
numReqs: &defaultNumberOfReqs,
duration: &defaultTestDuration,
url: "http://localhost:8080",
headers: noHeaders,
timeout: bigTimeoutDuration,
method: "GET",
body: "",
},
errLargeTimeout,
},
{
config{
numConns: defaultNumberOfConns,
Expand Down

0 comments on commit 00d7965

Please sign in to comment.