Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A component.json for Bower would be great #41

Closed
brianmhunt opened this issue Jan 21, 2013 · 3 comments
Closed

A component.json for Bower would be great #41

brianmhunt opened this issue Jan 21, 2013 · 3 comments
Labels

Comments

@brianmhunt
Copy link

It would be wonderful to have toastr in the Bower database.

@johnpapa
Copy link
Member

johnpapa commented Feb 2, 2013

Feel free to create this. I'm not up on how it works and I'm slammed for time.

@johnpapa johnpapa closed this as completed Feb 2, 2013
@brianmhunt
Copy link
Author

Thanks @johnpapa. Two things are required on your end:

  1. Using SemVer versioning i.e. Use SemVer for next version #42 and
  2. Pushing tags of each version to GitHub eg "v1.1.5"

I should be able to take care of the balance.

Cheers

@Iristyle
Copy link
Contributor

I see that you've decided to rename toastr.js to toastr-1.1.5.js.

I'd like to recommend against doing this because it's going to cause problems for automated builds that use Bower. Essentially this makes extra work for consumers of toastr because in addition to bumping the toastr version in the projects component.json, any includes now have to change, whether they're RequireJS based or inline script tags.

We're consuming about a dozen packages in Bower, and the approach you've taken is definitely not the norm.

In our case, we're using a combo of Grunt and RequireJS to handle dependency management, and this requires two mods to our source to bump toastr versions, instead of the just one of other packages.

I'll send a PR for the component.json -- the toastr.js file is referenced there as well, so having the script named with a version attached adds work for you at each version bump as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants