You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I see that you've decided to rename toastr.js to toastr-1.1.5.js.
I'd like to recommend against doing this because it's going to cause problems for automated builds that use Bower. Essentially this makes extra work for consumers of toastr because in addition to bumping the toastr version in the projects component.json, any includes now have to change, whether they're RequireJS based or inline script tags.
We're consuming about a dozen packages in Bower, and the approach you've taken is definitely not the norm.
In our case, we're using a combo of Grunt and RequireJS to handle dependency management, and this requires two mods to our source to bump toastr versions, instead of the just one of other packages.
I'll send a PR for the component.json -- the toastr.js file is referenced there as well, so having the script named with a version attached adds work for you at each version bump as well.
It would be wonderful to have toastr in the Bower database.
The text was updated successfully, but these errors were encountered: