Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #17

Merged
merged 7 commits into from Sep 2, 2016
Merged

Update Dockerfile #17

merged 7 commits into from Sep 2, 2016

Conversation

mlocher
Copy link
Contributor

@mlocher mlocher commented Sep 2, 2016

  • Switch from debian:latest to debian:jessie
  • Add MAINTAINER
  • Clean up apt cache after running the Heroku CLI installation script

* Switch from `debian:latest` to `debian:jessie`
* Add MAINTAINER
* Clean up apt cache after running the Heroku CLI installation script
@rheinwein
Copy link

Dockerfile changes look good 👍

@mlocher
Copy link
Contributor Author

mlocher commented Sep 2, 2016

Yeah, it's finally green. I'm currently using my Heroku credentials, but I created #18 to remedy this.

@rheinwein could you take another look (way more changes than just the Dockerfile now), thanks.

@rheinwein
Copy link

Looks good @mlocher. Nice to see the simplified caching changes :-D

@mlocher mlocher merged commit a6784b8 into master Sep 2, 2016
@mlocher mlocher deleted the updates branch September 2, 2016 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants