Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

第一次执行的命令失败为何不报错 #70

Closed
DoctorQ opened this issue Mar 21, 2019 · 1 comment
Closed

第一次执行的命令失败为何不报错 #70

DoctorQ opened this issue Mar 21, 2019 · 1 comment

Comments

@DoctorQ
Copy link

DoctorQ commented Mar 21, 2019

问题描述

bin/gosuv -c conf/config.yml start-server

启动命令为

pipenv1

当我启动程序时,虽然这个pipenv1执行的时候报错了,但是gosuv仍然打印了:

server started, listening  .gosuv.sock

造成我以为程序执行成功了,但是这种情况gosuv为何不报错了?

我看了下actions里面的源码,发现作者并没有对命令的执行结果做任何异常处理,有点疑惑

if c.Bool("foreground") {
		suv.AutoStartPrograms()
		log.Printf("server listen on %v", addr)
		log.Fatal(http.ListenAndServe(addr, nil))
} else {
....
}

疑惑

是故意这么设计的么,对第一次启动不做处理?即使执行失败,也让gosuv监听这种错误的脚本。

@codeskyblue
Copy link
Owner

这个项目很久不维护了,非常感谢你的关注。

Sent with GitHawk

@DoctorQ DoctorQ closed this as completed Mar 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants