Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI: Add Python 3.8 to the testing #1401

Merged
merged 5 commits into from Jan 15, 2020

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 26, 2019

Running codespell on Python 3.8 generates RuntimeWarnings...

$ codespell

/home/travis/virtualenv/python3.8.0/lib/python3.8/codecs.py:905:
RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode,
    the default buffer size will be used
file = builtins.open(filename, mode, buffering)

See: https://travis-ci.org/codespell-project/codespell/jobs/629584864#L430-L431

Py38 generates RuntimeWarnings...

$ __codespell__
```
/home/travis/virtualenv/python3.8.0/lib/python3.8/codecs.py:905:
RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode,
    the default buffer size will be used
file = builtins.open(filename, mode, buffering)
```
Copy link
Collaborator

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis change LGTM, but presumably we should be fixing the warning too...

Copy link
Collaborator

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, I'll let the grown-ups take a look too.

codespell_lib/_codespell.py Outdated Show resolved Hide resolved
@larsoner larsoner merged commit 33647e2 into codespell-project:master Jan 15, 2020
@larsoner
Copy link
Member

Thanks @cclauss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants