Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TrueBrain/actions-flake8 github action to v2 #2073

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Update TrueBrain/actions-flake8 github action to v2 #2073

merged 2 commits into from
Sep 23, 2021

Conversation

bwitt
Copy link
Contributor

@bwitt bwitt commented Sep 21, 2021 •
edited

Update github action Flake8 with annotations to v2

peternewman
peternewman approved these changes Sep 22, 2021
View reviewed changes
Copy link
Collaborator

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a query about pinning to a specific version (and therefore requiring us to keep upgrading in future).

.github/workflows/codespell-private.yml Outdated Show resolved Hide resolved
@peternewman peternewman mentioned this pull request Sep 22, 2021
Merged
@peternewman peternewman mentioned this pull request Sep 22, 2021
Closed
@bwitt bwitt changed the title Update TrueBrain/actions-flake8 to latest and pin flake8 to current latest Update TrueBrain/actions-flake8 github action to v2 Sep 23, 2021
peternewman
peternewman approved these changes Sep 23, 2021
View reviewed changes
Copy link
Collaborator

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks.

@peternewman peternewman self-assigned this Sep 23, 2021
@peternewman
Copy link
Collaborator

@DimitriPapadopoulos do you want to re-review too?

@DimitriPapadopoulos
Copy link
Collaborator

Perfect. And indeed if the CI fails on us too often, we may have to reconsider pinning versions.

@peternewman peternewman merged commit 8cbc66d into codespell-project:master Sep 23, 2021
@bwitt bwitt deleted the bwitt-patch-1 branch September 23, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitriPapadopoulos DimitriPapadopoulos DimitriPapadopoulos left review comments

@peternewman peternewman peternewman approved these changes

Assignees

@peternewman peternewman

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bwitt @peternewman @DimitriPapadopoulos