refactor: Add Access Modifer

클래스 내부의 속성 접근 제한자 설정 issue:#27
codesquad-members-2021 · Apr 23, 2021 · 624cf29 · 624cf29
1 parent 1dc0e54
commit 624cf29
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 18 deletions.
diff --git a/iOS/SideDish/SideDish.xcworkspace/xcuserdata/shim.xcuserdatad/UserInterfaceState.xcuserstate b/iOS/SideDish/SideDish.xcworkspace/xcuserdata/shim.xcuserdatad/UserInterfaceState.xcuserstate
diff --git a/iOS/SideDish/SideDish/Data/Network/DataMapping/BanchanListDTO+Mapping.swift b/iOS/SideDish/SideDish/Data/Network/DataMapping/BanchanListDTO+Mapping.swift
@@ -8,20 +8,20 @@
 import Foundation
 
 struct BanchanListDTO: Codable {
-    let body: [BanchanListItemDTO]
+    private let body: [BanchanListItemDTO]
 }
 
 extension BanchanListDTO {
     struct BanchanListItemDTO: Codable {
-        let detailHash: String
-        let image: String
-        let alt: String
-        let deliveryType: [String]
-        let description: String
-        let title: String
-        let nPrice: String?
-        let sPrice: String
-        let badge: [String]?
+        private let detailHash: String
+        private let image: String
+        private let alt: String
+        private let deliveryType: [String]
+        private let description: String
+        private let title: String
+        private let nPrice: String?
+        private let sPrice: String
+        private let badge: [String]?
 
         func toDomain() -> Banchan {
             return .init(detailHash: detailHash, image: image, alt: alt, title: title, description: description, nPrice: nPrice, sPrice: sPrice, badge: badge, deliveryType: deliveryType)

diff --git a/iOS/SideDish/SideDish/Presentaion/BanchanList/View/BanchanCustomCell.swift b/iOS/SideDish/SideDish/Presentaion/BanchanList/View/BanchanCustomCell.swift
@@ -18,10 +18,6 @@ class BanchanCustomCell: UICollectionViewCell {
 
     static let identifer = "BanchanCustomCell"
 
-    override func awakeFromNib() {
-        super.awakeFromNib()
-    }
-
     static var nib: UINib {
         return UINib(nibName: identifer, bundle: nil)
     }

diff --git a/iOS/SideDish/SideDish/Presentaion/BanchanList/View/BanchanListViewController.swift b/iOS/SideDish/SideDish/Presentaion/BanchanList/View/BanchanListViewController.swift
@@ -12,9 +12,9 @@ class BanchanListViewController: UIViewController {
 
     @IBOutlet weak var banchanCollectionView: BanchanCollectionView!
 
-    var viewModel = BanchanListViewModel()
-    lazy var dataSource = configureDataSource()
-    var subscriptions = Set<AnyCancellable>()
+    private var viewModel = BanchanListViewModel()
+    private lazy var dataSource = configureDataSource()
+    private var subscriptions = Set<AnyCancellable>()
 
     typealias DataSource = UICollectionViewDiffableDataSource<Section, Banchan>
     typealias Snapshot = NSDiffableDataSourceSnapshot<Section, Banchan>

diff --git a/iOS/SideDish/SideDish/Presentaion/BanchanList/ViewModel/BanchanListViewModel.swift b/iOS/SideDish/SideDish/Presentaion/BanchanList/ViewModel/BanchanListViewModel.swift
@@ -16,7 +16,7 @@ class BanchanListViewModel {
     }
 
     @Published var menu: Dictionary<Section, [Banchan]>
-    var network = NetworkSerivce.shared
+    private var network = NetworkSerivce.shared
 
     init() {
         self.menu = [:]