-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Team-13][BE][제리&쿠킴] - 요구사항 분석, Mockup API, 프로젝트 초기 세팅 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 대표 readme.md 추가(프로젝트, 팀원, wiki 소개) Refs #1
docs: .github 이슈, PR 템플릿 작성
[공통] 프로젝트 소개 docs 추가
- java 11 - spring-web - spring data JPA - h2 database - lombok - MySQL - Swagger
[BE] - 프로젝트 초기세팅
- rest-assured 의존성 추가 - 이벤트 메인 배너 인수 테스트 코드 작성
wooody92
added a commit
that referenced
this pull request
May 25, 2022
[Team-15][BE] 포키&나단의 airbnb 프로젝트 PR #1
tmdgusya
pushed a commit
that referenced
this pull request
May 25, 2022
jeonyeonkyu
pushed a commit
that referenced
this pull request
May 25, 2022
* 🎉 create-react-app * 📦️ ESLint 설치 - airbnb로 설정 - eslint-config-airbnb 설치 * 📦️ Prettier 설치 - eslint-config-prettier 설치 * 🔧 절대 경로 설정 * 📦️ TypeScript 설치 closed #1 * 📝 README 작성 - 프로젝트 기간 - 팀원 - Wiki * 💄 GlobalStyles 추가 Co-authored-by: ju-kkim <ju-kkim@users.noreply.github.com> * 💄 color 생성 * 💄 공통으로 적용할 수 있는 CSS 속성 utils.js에 정의 - box-shadow - position absolute 중앙 정렬 * 💄 Modal 컴포넌트 뷰 생성 * 💄 Modal 컴포넌트 뷰 생성 - ReservationModal - SearchBarModal closed #15 Co-authored-by: ju-kkim <ju-kkim@users.noreply.github.com> Co-authored-by: ju-kkim <ju-kkim@users.noreply.github.com>
- Controller, Service, Repository 계층 분할 구현 - Service 계층 테스트 추가
- 현재는 실패하는 테스트 - 더미데이터는 이후에 추가 예정
…main [BE] - 이벤트 도메인 기능 구현
- 위경도 있는 경우 - 위경도 없는 경우
- GET /api/place 요청 받는 컨트롤러 구현 - Service 구현중
- 리포지토리를 제외한 컨트롤러부터 서비스까지 커맨드 구현 - 주요 지역(e.g. 서울, 대전...) 정보를 위한 Place 객체 생성 - 위경도 관리를 위한 Position 객체 생성
- 올바르지 않은 위도, 경도값 (e.g. 위도 -200) 입력 시 예외 처리
…ory.findByPosition() -> findAll()
- 유틸성 객체 MapUtils.distance()의 계산 로직 구현 - Place.calculateTime() 메소드 구현, 단위 테스트 구현
- PlaceRepository.findAll 기능 구현 - PlaceService Transactional(readOnly = true) 어노테이션 추가
[BE] - 가까운 여행지 조회 기능
junu0516
pushed a commit
that referenced
this pull request
May 26, 2022
JasonLee0223
added a commit
that referenced
this pull request
May 27, 2022
JasonLee0223
added a commit
that referenced
this pull request
May 27, 2022
JasonLee0223
added a commit
that referenced
this pull request
May 27, 2022
JasonLee0223
added a commit
that referenced
this pull request
May 27, 2022
검색 - SearchViewController 위시리스트 - WishlistViewController 내 예약 - ReservationViewController
JasonLee0223
added a commit
that referenced
this pull request
May 27, 2022
JasonLee0223
added a commit
that referenced
this pull request
May 27, 2022
JasonLee0223
added a commit
that referenced
this pull request
May 27, 2022
JasonLee0223
added a commit
that referenced
this pull request
May 27, 2022
JasonLee0223
added a commit
that referenced
this pull request
May 27, 2022
JasonLee0223
added a commit
that referenced
this pull request
May 27, 2022
JasonLee0223
added a commit
that referenced
this pull request
May 27, 2022
JasonLee0223
added a commit
that referenced
this pull request
May 27, 2022
sally4405
pushed a commit
that referenced
this pull request
May 27, 2022
- Swift Package Manager로 RxSwift, Alamofire 패키지 등록 - 새 프로젝트 생성
sally4405
pushed a commit
that referenced
this pull request
May 27, 2022
sally4405
pushed a commit
that referenced
this pull request
May 27, 2022
저희가 실수로 PR을 보낸 브랜치에서 계속 작업을 해서 추가 commit이 달리게 되었네요 😭 죄송합니다. 다음부터는 조심 하겠습니다. 좋은 리뷰 감사합니다!! |
리뷰 감사합니다 🙇♂️ +a 이번 PR과, 오늘(05/27 금) 보낼 PR이 겹치는 관계로 머지하고 새로운 PR 보내려합니다. 감사합니니다. |
SangHwi-Back
added a commit
that referenced
this pull request
May 27, 2022
공통으로 사용할 색상과 이미지를 등록하였습니다.
junseokseo9306
added a commit
that referenced
this pull request
May 27, 2022
junseokseo9306
added a commit
that referenced
this pull request
May 27, 2022
junseokseo9306
pushed a commit
that referenced
this pull request
May 27, 2022
junseokseo9306
pushed a commit
that referenced
this pull request
May 27, 2022
Figma에 Text Style 항목을 참조하여 폰트 설정
junseokseo9306
pushed a commit
that referenced
this pull request
May 27, 2022
Figma의 Color Styles를 참조하여 Color 값 설정
junseokseo9306
pushed a commit
that referenced
this pull request
May 27, 2022
Figma에 정의된 colorPrimary 적용
yeonnseok
pushed a commit
that referenced
this pull request
May 27, 2022
프로젝트 생성 - Gradle 환경 - 의존성추가(Validation, Spring Web, MySQL, Lombok)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요
peter
!제리
와쿠킴
입니다.첫 PR은 코드 구현 없이 요구사항 분석, Mockup API, 프로젝트 초기 세팅하였습니다.
특별한 점으로 요구사항 분석하며 Event Storming을 하였고, 클라이언트 개발자를 위해 API 문서, Mock API 서버를 만들었습니다.
3주 기간 동안 리뷰 잘 부탁드립니다. 감사합니다. 🙇♂️
📝Description
요구사항 분석(Event Storming, Boris diagram, Snap-E)
API 문서와 Mockup API Server
Reference