Skip to content

pr rule

ryan-kim-dev edited this page Sep 18, 2022 · 2 revisions

PR ์š”์ฒญ

PR ์š”์ฒญ ์ œ๋ชฉ

  • pr ์š”์ฒญ ์‹œ ๊ธ€ ์ œ๋ชฉ์˜ Dev fe๋‚˜ Dev Be๋ฅผ ์ง€์›Œ์ฃผ์‹œ๊ณ , ์ปค๋ฐ‹ ๋ฉ”์„ธ์ง€ ๋‚ด์šฉ์œผ๋กœ ๋Œ€์ฒดํ•ฉ๋‹ˆ๋‹ค. ์•ž์— [client] ๋˜๋Š” [server] ๋ฅผ ๋ถ™์—ฌ์ฃผ์„ธ์š”.

  • ์˜ˆ์‹œ: [client] feat: ๋กœ๊ทธ์ธ, ํšŒ์›๊ฐ€์ž… ๋กœ์ง ๊ตฌํ˜„

PR ์š”์ฒญ ๋‚ด์šฉ

  • [ PR ์š”์ฒญ๋‚ด์šฉ์„ ์ ์–ด์ฃผ์„ธ์š”. ์ƒ์„ธํ•˜๋ฉด ๋”์šฑ๋” ์ข‹์Šต๋‹ˆ๋‹ค. ] ex) Oauth 2.0์„ ์ด์šฉํ•ด์„œ ์นด์นด์˜ค ๋กœ๊ทธ์ธ & ์นด์นด์˜ค ๋กœ๊ทธ์•„์›ƒ ๊ธฐ๋Šฅ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

Issues ๋‚ด์šฉ

  • [ ์ˆ˜์ •ํ•œ ๋‚ด์šฉ์ด๋‚˜ ๋ฒ„๊ทธ๊ฐ€ ์—†๋‹ค๋ฉด ์ง€์›Œ์ฃผ์„ธ์š”. ]

์ฐธ๊ณ  ๋งํฌ & ์Šคํฌ๋ฆฐ์ƒท

  • [ Issues ํ•ด๊ฒฐ์— ๊ด€ํ•œ ๋„์›€์„ ์ค„ ์ˆ˜ ์žˆ๋Š” ๋งํฌ๋‚˜ ์Šคํฌ๋ฆฐ์ƒท์„ ์˜ฌ๋ ค์ฃผ์„ธ์š”. Issues๊ฐ€ ์—†์œผ๋ฉด ์ง€์›Œ์ฃผ์„ธ์š”. ]

์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ปค๋ฐ‹ ์ปจ๋ฒค์…˜ ์ค€์ˆ˜ (feat, fix, refactor, design, chore)
  • Pull Request ๋Œ€์ƒ ํŒŒ์ผ ํ™•์ธ
  • Branch ํ™•์ธ
  • Labels ํ™•์ธ