Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar Graph not ready for negative values #138

Open
diversos opened this issue Aug 8, 2017 · 7 comments
Open

Bar Graph not ready for negative values #138

diversos opened this issue Aug 8, 2017 · 7 comments
Assignees

Comments

@diversos
Copy link

diversos commented Aug 8, 2017

How would you recommend fixing negative values in barChar? I can't explain properly, so I'll show you an example:

github_eg

2010: 0+0+0+0
2011: 0+0+0+0
2012: 0+0+0+0
2013: 0+5+8+0
2014: -38+0+13+0
2015: 45+12+130+0
2016: 0+0+0+0

I think that the xAxis should stay in y=0, and the negative values would go under it.

@codesuki
Copy link
Owner

codesuki commented Aug 9, 2017

That's interesting! I never considered that.
Let me ask if I understand you correctly.
13 should be on top of the x-axis and -38 should be below the x-axis?
So all negatives stack below and all positives stack above right?

@diversos
Copy link
Author

diversos commented Aug 9, 2017

Exacly! And several negatives would stack bellow each other. I don't think it should be too hard to implement, since you have the concept at the Scatter Graph.

@diversos
Copy link
Author

Did you have some time to try it?

@codesuki
Copy link
Owner

codesuki commented Sep 27, 2017

I tried it but there are still some unsolved issues.

  1. What to do with the labels?
  2. Special handling for grouped bar chart

See here:
image

@codesuki
Copy link
Owner

Fixed the grouped chart, but no good idea what to do with the labels.

image

@diversos
Copy link
Author

The only two options I see is either let it in the same place, but over the column bar, or push all the labels down, bellow the graphic.

@codesuki
Copy link
Owner

Yep, I can't see a much better way without total customization. I'll change the rendering order, I hope that's good enough.

@codesuki codesuki self-assigned this Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants