Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HorizontalBarChart chart #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add HorizontalBarChart chart #30

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 29, 2015

Something here doesn't seem quite right. It renders reasonably well but seems off.

screen shot 2015-04-29 at 12 10 40 pm

@codesuki
Copy link
Owner

codesuki commented May 1, 2015

Thanks for the pullreq.! I'll check. Sorry I didn't have time to properly answer the bar chart issue.
Which part of the screenshot do you feel is off?

@ghost
Copy link
Author

ghost commented May 1, 2015

The screenshot itself isn't off much, but if I play with the numbers and widths it can look very much out of place. I had to use some hacks in there as I wasn't terribly familiar with the code, I'm assuming one of them may be contributing to the problem.

@codesuki
Copy link
Owner

codesuki commented May 3, 2015

Ok, let me check if I can get rid of the hacks :)

@codesuki
Copy link
Owner

codesuki commented May 5, 2015

Just for your information, I am on holidays till Thursday. Sorry I can't check earlier!

@jsg2021
Copy link

jsg2021 commented Oct 7, 2015

+1... This would be nice!

@codesuki
Copy link
Owner

codesuki commented Oct 8, 2015

I will look for a way to implement this and be able to re-use the grouped bars option.

@jsg2021
Copy link

jsg2021 commented Oct 8, 2015

awesome! it may be nice to just make the bar chart go either direction based on data or a prop instead of having two components that are basicly the same.

@codesuki
Copy link
Owner

codesuki commented Oct 9, 2015

Yes I agree with that!

@codesuki codesuki mentioned this pull request Oct 27, 2016
@psudeepta
Copy link

@codesuki It would be very helpful if you can merge this. Could you please let me know as when it can be done?

@codesuki
Copy link
Owner

@psudeepta as @jsg2021 stated before I would like this component to be just integrated with the normal bar chart. Having a flag to switch between horizontal / vertical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants