Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add toml config #5

Merged
merged 12 commits into from Jun 22, 2022
Merged

feat: add toml config #5

merged 12 commits into from Jun 22, 2022

Conversation

oleggtro
Copy link
Contributor

this pr enables the user to be able to configure aoede not only with env vars but also with a config.toml

@oleggtro
Copy link
Contributor Author

could u maybe label the repo with hacktoberfest or this pr with hacktoberfest-accepted so that it counts towards my contribs?

codetheweb
codetheweb requested changes Oct 17, 2021
View reviewed changes
Copy link
Owner

@codetheweb codetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a config.sample.toml or something as an example?

src/main.rs Outdated Show resolved Hide resolved
@codetheweb
Copy link
Owner

I added the label to the repo so it hopefully should count.

@oleggtro
Copy link
Contributor Author

oh, didn't see it... I will push a change tomorrow

@codetheweb
Copy link
Owner

Looks good, just that last question on macro usage.

codetheweb
codetheweb reviewed Jun 21, 2022
View reviewed changes
Copy link
Owner

@codetheweb codetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finishing this up!

src/lib/config.rs Show resolved Hide resolved
src/lib/config.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@oleggtro oleggtro requested a review from codetheweb June 21, 2022 16:01
sibartel
sibartel reviewed Jun 21, 2022
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
codetheweb
codetheweb approved these changes Jun 22, 2022
View reviewed changes
Copy link
Owner

@codetheweb codetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@codetheweb codetheweb merged commit 1727887 into codetheweb:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sibartel sibartel sibartel left review comments

@codetheweb codetheweb codetheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oleggtro @codetheweb @sibartel