Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove missing closing tag #322

Merged
merged 1 commit into from Mar 28, 2015
Merged

Remove missing closing tag #322

merged 1 commit into from Mar 28, 2015

Conversation

igas
Copy link
Contributor

@igas igas commented Mar 28, 2015

No description provided.

@igas
Copy link
Contributor Author

igas commented Mar 28, 2015

Also, would you mind @schneems @prathamesh-sonpatki if I change layouts from sequential where open/closing tags in different partials, like open <body> in _head and closing </body> in _footer to something more semantical like entire <head> to something like _meta and all flash stuff to _flashes? I think it'll be cleaner and editors stop alerting inconsistent markups etc

prathamesh-sonpatki added a commit that referenced this pull request Mar 28, 2015
@prathamesh-sonpatki
Merge pull request #322 from igas/remove-missing-closing-tag
27bd84a 
Remove missing closing tag
@prathamesh-sonpatki prathamesh-sonpatki merged commit 27bd84a into codetriage:master Mar 28, 2015
@prathamesh-sonpatki
Copy link
Member

@igas Thanks 👍 . I guess changing layouts will be fine to make it consistent :)

@schneems
Copy link
Member

Thanks ❤️

That change sounds like a good one 👍

@arthurnn
Copy link
Member

HAML ! =)

@igas
Copy link
Contributor Author

igas commented Mar 30, 2015

@arthurnn 😄 I personally prefer slim, but erb was here originally. I started global refactoring of views, first pr #323 about layouts. We can discuss changing of template language and prevent double work. /cc @schneems @prathamesh-sonpatki

@schneems
Copy link
Member

schneems commented Apr 2, 2015

I have nothing against slim, i've heard great things about it.

For HAML...i've used it, and i'm mostly 👎 on HAML. I like the idea (indentation sensitive templates) however I'm not in love with the syntax

@igas igas mentioned this pull request Apr 20, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@igas @prathamesh-sonpatki @schneems @arthurnn