212 #213
Closed
212 #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kaustubhai Please remove |
|
Sorry. Must have missed it in that one. Deleted |
|
@kaustubhai Why is this PR so massive now? 9799 deletions? Have you completely deleted the package-lock.json file? Just do not track changes to package-lock.json. Not include it in your PRs. |
|
@ksraj123 So now should I copy the lock.json from main repo and send another PR? |
|
@kaustubhai I see that your PR uses commits from other PRs. This is not the best way to do things. I would suggest you to close all the PRs which depend upon changes made in your first PR and wait for that to be merged first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Github Issue Number: #212
Personal Overview was giving out the wrong information on the number of event and project created
Solution of problem
Modified the function and used proper methods to count the correct number
Type of Change
[x] Bugfix
[ ] New Feature
[ ] Development of UI/UX prototypes
[ ] Small refactor
[ ] Change in Documentation
Checklist
[x] My code follows the same style as the codebase
[ ] My Code change requires a change in documentation
[ ] I have updated the Readme accordingly
[x] I made PR against development branch
[x] I have run the test cases locally and it's passing.
[x] I have squashed my commits