[Fix #7] Use the libexec/ directory rather than bin/ for internal commands
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the "Filesystem Hierarchy Standard", libexec/ is meant for binaries that are not meant to be executed by other programs. This is where git stores all of its internal commands, e.g., git-add, git-commit, git-config, etc. This will fix the issue of `brew doctor` complaining about codeunion-config.
Currently the feature test for `codeunion-config` executes `bin/codeunion-config` directly. Rather than changing the test to execute `libexec/codeunion-config`, just use the user-facing interface: "codeunion config [OPTIONS]".
|
👍 🎉 |
zspencer
added a commit
that referenced
this pull request
Dec 27, 2014
…l-commands [Fix #7] Use the `libexec/` directory rather than `bin/` for internal commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By convention,
libexec/is used for binaries not meant to be executed directly by a user. This convention is "codified" in the Filesystem Hierarchy Standard. I learned this after investigating where and how git places its own internal commands, e.g.,git-add,git-commit,git-config, etc.This requires modifying
ENV["PATH"]in thebin/codeunionexecutable and fixes issue #7 (brew doctorcomplaining aboutcodeunion-configbeing in the user's PATH).