Feature: Support multiple project slugs #10
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
First of all: Thanks for this repo!
This PR:
set :sentry_project, 'my-foo my-bar'
),.rubocop.yml
is not deprecated andspec.required_ruby_version = '>= 2.5.0'
because I noticed that the code would fail running on 2.4.9 because ofString.delete_suffix
usage.Reasoning: I found myself in a position where I have separate frontend and backend projects in Sentry (to allow users to fine tune their notifications more easily), but one git repository for both project's code ("historical reasons"). Therefore I need to notify Sentry about one release being deployed to both projects. This PR intends to support exactly that.
Please let me know if i should split up these changes into several PRs or if any other changes are required.
Thanks!