Ensure custom theme attribute is evaluated correctly #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason jQuery#data returns true for attribute value "false". This caused legacy custom theme to be applied.
tf
force-pushed
the
theme-compat-fixes
branch
from
6decb86
to
9f991bf
Compare
tf
added a commit
to tf/pageflow-chart
that referenced
this pull request
Jul 12, 2017
Backport of codevise#28 For some reason jQuery#data returns true for attribute value "false". This caused legacy custom theme to be applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason jQuery#data returns true for attribute value
"false". This caused legacy custom theme to be applied.