Improve navigation tooltips #1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaismbajwa
force-pushed
the
custom-tooltip-for-scrolled
branch
from
677a59f
to
38c1341
Compare
awaismbajwa
force-pushed
the
custom-tooltip-for-scrolled
branch
7 times, most recently
from
88028c6
to
bf2e931
Compare
tf
force-pushed
the
custom-tooltip-for-scrolled
branch
from
bf2e931
to
7ecdb59
Compare
tf
force-pushed
the
custom-tooltip-for-scrolled
branch
from
c339d27
to
0d6cbac
Compare
Implemented a basic Tooltip in pageflow scrolled to solve the problem with react tooltip css in Server side rendering.
and focus issue of expanded menus
Compared to the previous JS based approach this has a couple of advantages: * Clicking outside of a tooltip closes it. Before, a tooltip could only be closed by clicking the icon again. * Closing other tooltips is taken care of automatically since opening a tooltip means the other tooltip loses focus. * Less JS logic, less things to test. * Also works in non-JS case. As a result, tooltips now already open when the menu icon is focused. Given that we have a skip link to skip the whole navigation this seems ok to me. Remove some unneeded code: * `hasTrigger` was always true. * Use CSS parent selector to make icons of expanded tooltips blue instead of cloning children and setting an additional class. REDMINE-17849
* Keep only currently needed variants. * Remove duplicate inline styles. * Fine tune transitions.
Prevent collapsing the navigation while tooltips are still visible when scrolling page.
tf
force-pushed
the
custom-tooltip-for-scrolled
branch
from
0d6cbac
to
44d36f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REDMINE-17849