Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn Theme into Plain Old Ruby Object #45

Merged
merged 6 commits into from Jul 2, 2014
Merged

Turn Theme into Plain Old Ruby Object #45

merged 6 commits into from Jul 2, 2014

Conversation

tf
Copy link
Member

@tf tf commented Jun 28, 2014

  • Adding themes amounts to a configuration change
  • Simplifies automatic precompilation registration in asset pipeline
  • Add generator to copy create theme template

UI Changes:

  • Allow editing themings via Accounts admin
  • Allow choosing entry Theming by Account name

tf added 5 commits June 28, 2014 15:53
@tf
replace theme model with plain ruby object
d4073c1 
register themes via configuration instead of creating them in database
migrations.

BREAKING CHANGE: the default theme has to be registered in the
pageflow initializer.
@tf
automatically register theme css files for precompile
ee511d3
@tf
theme generator
9f043c5 
add a rails generator to copy the default theme into the main app for
modification
@tf
editing theming attributes through account admin
b01d970 
allow changing imprint/copyright link text/url of account's nested
default theming
@tf
ensure theming belongs to account
f0b3f1a 
* associate theming with account on creation
* allow entry theming selection based on account name
This was referenced Jun 28, 2014
Closed
Closed
Closed
tf added a commit that referenced this pull request Jul 2, 2014
@tf
Merge pull request #45 from tf/theme-poro
5bcb2e4 
Turn Theme into Plain Old Ruby Object
@tf tf merged commit 5bcb2e4 into codevise:master Jul 2, 2014
@tf tf deleted the theme-poro branch August 18, 2014 09:48
@tf tf modified the milestone: v0.2 Dec 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tf