Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename all .css.scss to just .scss #566

Closed
wants to merge 1 commit into from
Closed

rename all .css.scss to just .scss #566

wants to merge 1 commit into from

Conversation

tilsammans
Copy link
Contributor

Fixes the deprecation warning since sass 3.4.

Script used:

#!/bin/zsh
for file in app/**/*.css.scss; do
  git mv ${file} ${file:gs/.css/}
done

@coveralls
Copy link

coveralls commented Jun 28, 2016

Coverage Status

Coverage decreased (-0.01%) to 97.617% when pulling a5a6c4f on scrollytelling:css-scss-to-scss-sass-3-4 into cad8bf5 on codevise:master.

@tf
Copy link
Member

tf commented Jun 28, 2016

Good idea. Maybe let's wait till I merged some of the PRs I have teed up to prevent conflicts and also catch some .css.scss files that might have been added there.

@tilsammans
Copy link
Contributor Author

Sure! Ping me when you feel it's ready, and I'll rebase and re-run the script.

@@ -0,0 +1 @@
@import "./default/base.scss";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imported partial ./default/base.scss should be written as ./default/base

@tf tf modified the milestone: v0.11 Jun 29, 2016
Fixes the deprecation warning since sass 3.4.

Script used:

```
for file in app/**/*.css.scss; do
  git mv ${file} ${file:gs/.css/}
done
```
@coveralls
Copy link

coveralls commented Jul 5, 2016

Coverage Status

Coverage decreased (-0.02%) to 97.622% when pulling 20503c5 on scrollytelling:css-scss-to-scss-sass-3-4 into 503d8b3 on codevise:master.

@tf
Copy link
Member

tf commented Aug 31, 2016

see #613

@tf tf closed this Aug 31, 2016
@tilsammans tilsammans deleted the css-scss-to-scss-sass-3-4 branch August 31, 2016 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants