Reorganize file seed data #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tf
commented
Dec 16, 2016
tf
commented
- Include file model type names in common seed
- Include file url templates in common seed
- Generate seed data for files
houndci-bot
reviewed
Dec 16, 2016
| @@ -37,4 +41,5 @@ def json_response(options = {}) | |||
|
|
|||
| RSpec.configure do |config| | |||
| config.include(JsonResponseHelper, :type => :controller) | |||
| config.include(JsonResponseHelper, :type => :helper) | |||
houndci-bot
reviewed
Dec 16, 2016
| [ | ||
| {attribute: 'thumbnail_image_id', file_collection: 'image_files'}, | ||
| {attribute: 'video_id', file_collection: 'video_files'} | ||
| ] |
There was a problem hiding this comment.
Indent the right bracket the same as the start of the line where the left bracket is.
houndci-bot
reviewed
Dec 16, 2016
| it 'includes thumbnail candidates of page types registered for entry' do | ||
| thumbnail_candidates = | ||
| [ | ||
| {attribute: 'thumbnail_image_id', file_collection: 'image_files'}, |
There was a problem hiding this comment.
Use 2 spaces for indentation in an array, relative to the start of the line where the left square bracket is.
houndci-bot
reviewed
Dec 16, 2016
| :'4k' => url_template(:mp4_4k), | ||
|
|
||
| :'hls-playlist' => url_template(:hls_playlist), | ||
| :'dash-playlist' => url_template(:dash_playlist), |
houndci-bot
reviewed
Dec 16, 2016
| }, | ||
| { | ||
| path: video_file.mp4_4k.url(host: :hls_origin, default_protocol: 'http'), | ||
| bandwidth: 32000 |
There was a problem hiding this comment.
Separate every 3 digits in the integer portion of a number with underscores(_).
houndci-bot
reviewed
Dec 16, 2016
| } | ||
| end | ||
|
|
||
| def mp4_low_definition | ||
| { | ||
| label: 'low', | ||
| format: 'mp4', | ||
| prepare_for_segmenting: ['hls', 'dash'], |
There was a problem hiding this comment.
Use %w or %W for an array of words.
houndci-bot
reviewed
Dec 16, 2016
| } | ||
| end | ||
|
|
||
| def mp4_medium_definition | ||
| { | ||
| label: 'medium', | ||
| format: 'mp4', | ||
| prepare_for_segmenting: ['hls', 'dash'], |
There was a problem hiding this comment.
Use %w or %W for an array of words.
houndci-bot
reviewed
Dec 16, 2016
| @@ -100,59 +72,198 @@ def mp4_fullhd_definition | |||
| def mp4_high_definition | |||
| { | |||
| label: 'high', | |||
| format: 'mp4', | |||
| prepare_for_segmenting: ['hls', 'dash'], | |||
There was a problem hiding this comment.
Use %w or %W for an array of words.
Can be used to map file type collection names to model type names in client side code.
Let file types provide a hash of file url template strings. Url templates are created lazily to allow using an actual example record in the construction of the url without triggering eager loading of the model during initialization.
Add a common json partial that is used by both the `FilesHelper`, which renders seed data for the editor, and the `EntryJsonSeedHelper`, which renders seed data for published entries. Let file types specify a custom partial that is included in these representations. Add id, parent file and basename to file seed data.
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.