Move file configuration to file usage #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that editing a file configuration cannot change already published entries. * Move `configuration` column to `file_usages` table * Split `Revision#files` scope into `find_files` and `find_file` methods and return `UsedFile` decorators which take the configuration from a file usage. * Move `FileUsagesController` actions to `FilesController` and make it act like a facade that hides the concept of file usages, always working with the usages from the entry draft. * Ensure file usages for nested files are created on file reuse. * Ensure file usages for nested files are deleted together with the parent's files file usage. * Get complete list of entry files after making a reuse request inside the editor. Ensure file types are associated correctly when files are added via `FilesCollection#set`.
houndci-bot
reviewed
Feb 7, 2017
| @@ -29,9 +29,9 @@ def file_duration(file) | |||
| end | |||
|
|
|||
| def files_json_seeds(entry) | |||
| inner = Pageflow.config.file_types.map do |file_type, result| | |||
| inner = Pageflow.config.file_types.map do |file_type| | |||
There was a problem hiding this comment.
Prefer {...} over do...end for multi-line chained blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that editing a file configuration cannot change already
published entries.
Move
configurationcolumn tofile_usagestableSplit
Revision#filesscope intofind_filesandfind_filemethods and return
UsedFiledecorators which take theconfiguration from a file usage.
Move
FileUsagesControlleractions toFilesControllerand make itact like a facade that hides the concept of file usages, always
working with the usages from the entry draft.
Ensure file usages for nested files are created on file reuse.
Ensure file usages for nested files are deleted together with the
parent's files file usage.
Get complete list of entry files after making a reuse request inside
the editor. Ensure file types are associated correctly when files
are added via
FilesCollection#set.