Ensure mobile video poster is displayed on Android #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the poster was only displayed if the `native_video_player` feature was present. This is only the case on iPhone. Now we show the poster on all phone platforms, but hide it while videos are playing if the `native_video_player` feature is not present. Otherwise the video being played inline would not be visible.
houndci-bot
reviewed
Sep 18, 2018
| } | ||
|
|
||
| // But not while playing inline (e.g. on Android) | ||
| &.has_no_native_video_player .videoPage.should_play .background_image { |
There was a problem hiding this comment.
Selector videoPage should match regex /^[-a-z0-9_]+$/
|
|
||
| .has_phone_platform { | ||
| // Show mobile poster only on phone platform | ||
| .videoPage .background_image { |
There was a problem hiding this comment.
Selector videoPage should match regex /^[-a-z0-9_]+$/
| @@ -0,0 +1,15 @@ | |||
| .videoPage .background_image { | |||
There was a problem hiding this comment.
Selector videoPage should match regex /^[-a-z0-9_]+$/
tf
added a commit
to tf/pageflow
that referenced
this pull request
Sep 26, 2018
Backport of codevise#994 Before the poster was only displayed if the `native_video_player` feature was present. This is only the case on iPhone. Now we show the poster on all phone platforms, but hide it while videos are playing if the `native_video_player` feature is not present. Otherwise the video being played inline would not be visible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the poster was only displayed if the
native_video_playerfeature was present. This is only the case on iPhone.
Now we show the poster on all phone platforms, but hide it while
videos are playing if the
native_video_playerfeature is notpresent. Otherwise the video being played inline would not be visible.
REDMINE-15810