Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The feedback UI is visible for not completed beta katas #2044

Closed
FArekkusu opened this issue Feb 27, 2020 · 3 comments
Closed

The feedback UI is visible for not completed beta katas #2044

FArekkusu opened this issue Feb 27, 2020 · 3 comments

Comments

@FArekkusu
Copy link

image

@FArekkusu
Copy link
Author

This UI is also visible for your own katas, which IIRC didn't happen in the past.

Also, Github couldn't process the issue submission properly, leaving a manual notification, @kazk.

@kazk kazk added the kind/bug label Feb 27, 2020
@kazk
Copy link
Member

kazk commented Feb 27, 2020

@FArekkusu

This UI is also visible for your own katas, which IIRC didn't happen in the past.

I'm pretty sure it was shown. #20 is about a wrong message shown to the author.

I thought this was also shown for not completed kata too. The "You must complete this kata before you can rank it" has been in the codebase for years.

Maybe it used to look like the following?

image

@kazk kazk added kind/bug? and removed kind/bug labels Feb 27, 2020
@FArekkusu
Copy link
Author

Due to the CSS rules getting messed up I thought that the standard "difficulty/satisfaction voting" UI was incorrectly rendered:

image

It's weird to see "your feedback" section when you cannot provide any, but that's not a (serious) issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants