Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate "Rock, Paper, Scissors, Lizard, Spock" #66

Closed
4 tasks done
hobovsky opened this issue Jan 24, 2022 · 15 comments
Closed
4 tasks done

Deduplicate "Rock, Paper, Scissors, Lizard, Spock" #66

hobovsky opened this issue Jan 24, 2022 · 15 comments
Assignees
Labels
discussion/deduplicate Discussion and vote what to do with duplicate kata

Comments

@hobovsky
Copy link
Contributor

hobovsky commented Jan 24, 2022

  1. Rock Paper Scissors Lizard Spock
  • 7kyu
  • 88% satisfaction, 489 solutions
  • 1 pending issue about being a duplicate
  • 3 languages + 1 pending translation
  • Published Sep 2016, author active
  1. Rock, Paper, Scissor, Lizard, Spock Game
  • 6kyu
  • The only difference with 1. is that this one is case-insensitive and checks for invalid inputs.
  • 89% satisfaction, 448 solutions
  • No pending issues
  • 3 languages + 3 pending translations
  • Published Jan 2016, author inactive

Since both kata are nearly identical in terms of requirements, satisfaction, solutions, pending issues, and even publication date, the only criteria affecting the choice for keeping one and retiring the other are probably ranking, and available languages.

Languages:

image

Conclusion

Filling gaps

  • Move Ruby approved translation from 2. to 1.
  • Move Java pending translation from 2. to 1.
  • Think of a better description, maybe moving the image from 2. to 1.
@hobovsky hobovsky added the discussion/deduplicate Discussion and vote what to do with duplicate kata label Jan 24, 2022
@hobovsky
Copy link
Contributor Author

My vote:

This time, I have no clear candidate for keeping, or for retirement. I lean towards keeping 1. because I think the rank is a bit better, and I do not like the input validation in 2. 2. has more languages, but languages present in 2. and missing in 1. can be transferred after deduplication.

@ejini6969
Copy link

ejini6969 commented Jan 24, 2022

This is a hard one to make a decision. The 1st one is a subset of 2nd one, so I lean towards keeping the 2nd one. Plus, the 2nd one has more translations (including pending) and has earlier creation data. Also its rank is more appropriate (it is important for users to check for input validness IMO), but the description needs to be clearer on what inputs are considered to be invalid (can be copied from the 1st one).

EDIT: Change my mind, retire 2 due to require effort in transferring languages to 1. (But IMO the picture in 2 should definitely be transferred to 1.)

@hobovsky
Copy link
Contributor Author

hobovsky commented Jan 24, 2022

So I count your vote as "keep and fix 2., retire 1." right?

EDIT: ejini changed his vote.

@Blind4Basics
Copy link

retire 2, because the author is inactive.

@Madjosz
Copy link

Madjosz commented Jan 24, 2022

  1. uses the wrong word "scissor". This word is only used in plural "scissors" because it's referring to the pair of scissor blades.

@hobovsky
Copy link
Contributor Author

  1. uses the wrong word "scissor". This word is only used in plural "scissors" because it's referring to the pair of scissor blades.

Oh right, I forgot to raise an issue about this.
But still, it's fixable and can be handled after the deduplication concludes.

@krishsharma0413
Copy link

keep and fix 2, retire 1

for no other reason than more lang support and have more checks and also an image in description.
but what i think makes it 6kyu is not what i am sure of tho maybe derank to 7kyu? also the description isnt as elaborated as the first.

@EloiseRosen
Copy link

vote for keep 1, retire 2

@akar-0
Copy link

akar-0 commented Apr 3, 2022

Keep 1, retire 2, overrranked. Description of 1 can be improved easily.

@wtlgo
Copy link

wtlgo commented Aug 12, 2022

I don't think that validation is a necessary part of the such kata. I vote to keep 1

@Blind4Basics
Copy link

Blind4Basics commented Aug 12, 2022

retire 2 (edit: oops, I already voted above... XD ).

Maybe add the picture of 2 in the description of 1? (it's on imgur)

@KayleighWasTaken
Copy link

Keep 1, transfer languages from 2.

@hobovsky
Copy link
Contributor Author

hobovsky commented Aug 12, 2022

Discussion can be concluded as keep 1., retire 2. Before retirement is requested, following changes need to be done:

  • Move Ruby approved translation from 2. to 1.
  • Move Java pending translation from 2. to 1.
  • Think of a better description, maybe moving the image from 2. to 1.

@EloiseRosen
Copy link

EloiseRosen commented Aug 12, 2022

I'll do # 3 (description)

@hobovsky
Copy link
Contributor Author

Moved Ruby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion/deduplicate Discussion and vote what to do with duplicate kata
Projects
Development

No branches or pull requests

10 participants