Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate - vowel / consonant count #70

Closed
2 tasks done
hobovsky opened this issue Jan 26, 2022 · 5 comments
Closed
2 tasks done

Deduplicate - vowel / consonant count #70

hobovsky opened this issue Jan 26, 2022 · 5 comments
Assignees
Labels
discussion/deduplicate Discussion and vote what to do with duplicate kata

Comments

@hobovsky
Copy link
Contributor

hobovsky commented Jan 26, 2022

  1. Vowel Count
  • 7kyu
  • Inputs with lowercase alpha chars and spaces
  • Satisfaction 88%, 214k solutions
  • 2 pending issues, random tests missing in some languages
  • 25 languages + 3 pending translations
  • Published Mar 2015, author last active Dec 2021
  1. count vowels in a string
  • 7kyu
  • Inputs with lower- and uppercase characters; spaces and asterisks only in fixed test; mixed types in input
  • Satisfaction 88% satisfaction, 1k solutions
  • No pending issues
  • Python and Ruby only
  • Published Jul 2015, author inactive
  1. Count vowels
  • 7kyu
  • Inputs with lowercase alpha and spaces
  • Satisfaction 74%, 215 solutions
  • One pending issue about missing random tests in all languages
  • Only 3 FP languages: Haskell, F#, OCaml, and only Haskell is present in 1.
  • Published Aug 2016, author active
  1. Count consonants
  • 7kyu
  • Count consonants instead of vowels; inputs contain lowercase characters, and in fixed tests additionally selection of uppercase and non-alpha chars
  • Satisfaction 91%, 1500 solutions
  • No pending issues
  • 7 languages, no pending translations
  • Published Nov 2015, author inactive

Questions:

  • Is 2. a duplicate or not, if it tests uppercase characters while other kata don't?
  • \3. seems to be an exact duplicate of 1., but has almost unique selection of languages. What to do with it?
  • Is 4. a duplicate or not, if the difference is consonants instead of vowels?

Conclusion:

@hobovsky hobovsky added the discussion/deduplicate Discussion and vote what to do with duplicate kata label Jan 26, 2022
@hobovsky
Copy link
Contributor Author

hobovsky commented Jan 26, 2022

My vote:

  • Keep 1. as the most complete of all candidates.
  • Retire 2. I think upper- and lower-case letters are not enough of a difference.
  • Retire 3., add corresponding translations to 1.
  • Retire 4. as its solution (compared to 1.) boils down only to changing the allowed character set (but please see posts below).

@error256
Copy link

Keep 1, which, among other things, is the oldest, retire 2 and 3.
But I'm not sure about 4: the set of characters to check is larger (discourages using a chain of ==-or) and case-insensitiveness allows using the corresponding regexp flag or case conversions. Are these differences significant for a 7 kyu or not? I'm OK with either choice.

@hobovsky
Copy link
Contributor Author

It's just now when I noticed that 4. tests for uppercase letters in fixed tests. In such case, error256's doubts related to larger character set with case insensitivity are more justified.
I am not sure now. Please say what you think about 4.

@Blind4Basics
Copy link

  • keep 1 and 4 (because, well, "some variety", like error256 pointed out)
  • retire 2 and 3

@ejini6969
Copy link

I agree with B4B (changed my vote)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion/deduplicate Discussion and vote what to do with duplicate kata
Projects
Development

No branches or pull requests

5 participants