Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping past the arguments stack causes test display to show wrong numbers #6

Closed
Voileexperiments opened this issue Aug 8, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Voileexperiments
Copy link

Let's say I have the simplest function ever:

: cat ;

s" example" describe#{
  s" returns what is passed in" it#{
    <{ 1 cat -> 1 }>
  }#
}#

The integer stack actually has 4 values below the input argument:

image

Dropping past them will cause problems. Besides #1, it also causes the display to become something like Wrong number of results, expected -3 , got -4.

@nomennescio
Copy link
Collaborator

Showing the wrong number of results in case of stack underflow is a "feature" of the original test framework. I'll see if I can gently fix that without causing too much problems.

@nomennescio nomennescio added the bug Something isn't working label Aug 8, 2019
kazk added a commit that referenced this issue Aug 9, 2019
Fix dropping past the arguments stack causes test display to show wrong numbers (#6)
@kazk
Copy link
Member

kazk commented Aug 9, 2019

I'll close this when #9 is deployed.

@kazk
Copy link
Member

kazk commented Aug 12, 2019

Deployed

@kazk kazk closed this as completed Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants