Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moar options: REST format, custom headers #16

Merged
merged 6 commits into from
Jan 30, 2015
Merged

Moar options: REST format, custom headers #16

merged 6 commits into from
Jan 30, 2015

Conversation

aseemk
Copy link
Collaborator

@aseemk aseemk commented Jan 29, 2015

Fixes #10
Fixes #13

Simplified implementation from what I proposed in the issues in a few minor ways.

TAL and LMK if anything needs changing. Thanks!

This was referenced Jan 29, 2015
@aseemk
Copy link
Collaborator Author

aseemk commented Jan 29, 2015

The tests pass for me locally, but some of the tests (all pre-existing) are timing out on Travis. Is that expected?

https://travis-ci.org/brian-gates/cypher-stream/builds/48833527

And set to reasonably high for Travis.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.66%) to 92.46% when pulling 7ee8a1c on aseemk:options-api into d6f50a1 on brian-gates:master.

@aseemk
Copy link
Collaborator Author

aseemk commented Jan 29, 2015

Checked in a mocha.opts file to increase the global Mocha timeout to 5 secs, up from the default of 2s (and the "slow" marker to 1s, up from 75ms), for Travis. Tests pass now. Hope that's cool?

brian-gates added a commit that referenced this pull request Jan 30, 2015
Moar options: REST format, custom headers
@brian-gates brian-gates merged commit 3043988 into codex-digital:master Jan 30, 2015
@brian-gates
Copy link
Contributor

Looks good; I've made you a contributor by the way, so feel free to continue development as needed :)

@aseemk
Copy link
Collaborator Author

aseemk commented Jan 30, 2015

Thanks @brian-gates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for REST format Custom (and default?) headers
3 participants