Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement stop and resume functionality #66

Merged
merged 9 commits into from
May 14, 2024
Merged

Implement stop and resume functionality #66

merged 9 commits into from
May 14, 2024

Conversation

tinniaru3005
Copy link
Collaborator

@tinniaru3005 tinniaru3005 commented Mar 25, 2024 •
edited
Loading

Implement stop and resume functionality:

  • Stores simulation state information in pickle files.
  • Checks the last item in pickle files to accurately determine simulation completion
  • If simulation stop (when we press ctrl+z in terminal) then we can restart it using the command python3 study.py --restart=results/{execID}

@tinniaru3005
Implemented state saving and completion check using pickle files
705ab8a 
Signed-off-by: Arunima Chaudhuri <arunimachaudhuri2020@gmail.com>
@tinniaru3005
identify incomplete simulations
04090fd 
Signed-off-by: Arunima Chaudhuri <arunimachaudhuri2020@gmail.com>
@tinniaru3005
Clear code
ec0f9cc 
Signed-off-by: Arunima Chaudhuri <arunimachaudhuri2020@gmail.com>
@tinniaru3005
store config shape in pickle files
c4db8e4 
Signed-off-by: Arunima Chaudhuri <arunimachaudhuri2020@gmail.com>
@tinniaru3005
Implement stop and resume functionality
d591c17 
Signed-off-by: Arunima Chaudhuri <arunimachaudhuri2020@gmail.com>
@tinniaru3005 tinniaru3005 marked this pull request as ready for review March 27, 2024 20:39
@tinniaru3005 tinniaru3005 changed the title Implemented state saving and completion check using pickle files c4db8e4 @tinniaru3005 Implement stop and resume functionality Mar 28, 2024
@tinniaru3005 tinniaru3005 changed the title c4db8e4 @tinniaru3005 Implement stop and resume functionality Implement stop and resume functionality Mar 28, 2024
@tinniaru3005
Removed debug prints
2aa0074 
Signed-off-by: Arunima Chaudhuri <arunimachaudhuri2020@gmail.com>
@tinniaru3005
make the changes on study level
04004ed 
Signed-off-by: Arunima Chaudhuri <arunimachaudhuri2020@gmail.com>
@tinniaru3005
use shape for naming pickle files for restarting simulations
4ad181c 
Signed-off-by: Arunima Chaudhuri <arunimachaudhuri2020@gmail.com>
@tinniaru3005
Fixed simulation completion check
1935faf 
Signed-off-by: Arunima Chaudhuri <arunimachaudhuri2020@gmail.com>
@leobago
Copy link
Collaborator

leobago commented May 14, 2024

Thanks for the fixes!
We can merge now. :)

@leobago leobago merged commit ca9a0fa into develop May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tinniaru3005 @leobago