refactor: merging proving module into sales #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuHau
force-pushed
the
refactor/marketplace/merge-sales-proving
branch
3 times, most recently
from
f49e428
to
81b4b8f
Compare
emizzle
force-pushed
the
feat/marketplace/request-queue
branch
7 times, most recently
from
ca1b86a
to
4672f5a
Compare
AuHau
force-pushed
the
refactor/marketplace/merge-sales-proving
branch
3 times, most recently
from
015a818
to
1de49f7
Compare
emizzle
previously approved these changes
Aug 15, 2023
Co-authored-by: Eric <5089238+emizzle@users.noreply.github.com> Signed-off-by: Adam Uhlíř <adam@uhlir.dev>
Co-authored-by: Eric <5089238+emizzle@users.noreply.github.com> Signed-off-by: Adam Uhlíř <adam@uhlir.dev>
AuHau
force-pushed
the
refactor/marketplace/merge-sales-proving
branch
from
5a8f982
to
cea8a0a
Compare
emizzle
reviewed
Aug 16, 2023
Co-authored-by: Eric <5089238+emizzle@users.noreply.github.com> Signed-off-by: Adam Uhlíř <adam@uhlir.dev>
AuHau
force-pushed
the
refactor/marketplace/merge-sales-proving
branch
from
064dd53
to
7259226
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #414
Implementation of the simulated proof failure follows a similar path as it was implemented now - a separate state that inherits from the original proving with only
provemethod overridden.