Simplify empty cid handling #497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elcritch
commented
Aug 2, 2023
|
|
||
| proc emptyCid*(version: CidVersion, codex: MultiCodec): ?!Cid = |
There was a problem hiding this comment.
@dryajov not sure what but the previous templates combined with ORC were causing lots of defects trying to access a Result error that didn't exist.
My hunch is that all the error catches and gets needed for the tables were causing issues unrelated to ORC itself. The templates were giving me issues on the 1.6.14 update as well. So perhaps just trying to do all the error wrapping in a once block in the template was causing issues.
Probably a compiler limitation but I figure no reason to push it there. Plus this makes it easier to call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.