Slows down block maintenance iteration #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbekas
approved these changes
Sep 4, 2023
| @@ -78,6 +78,7 @@ proc runBlockCheck(self: BlockMaintainer): Future[void] {.async.} = | |||
| if be =? await maybeBeFuture: | |||
| inc numberReceived | |||
| await self.processBlockExpiration(be) | |||
| await sleepAsync(50.millis) | |||
There was a problem hiding this comment.
Maybe we can do it as a configuration param?
There was a problem hiding this comment.
Or something we can remove once we get non-blocking IO in. It looks like this might just give time for the network async items to catch up? But yah, it'd be nice to have something a bit more concrete long term.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combined with #536 have greatly improved node stability and network stability in the continuous testing environment.